Shi Hong's Project Portfolio Page
Project: AgentSee
Given below are my contributions to the project.
-
Code contributed: My code contribution can be found here [RepoSense]
- Enhancement:
- Added
edit-scommand feature- What it does: This command allows the user to edit the details of a seller
- Justifications: The basic CRUD command for the seller information.
- Credits: The feature was implemented by referring to AddressBook Level 3 (AB3) edit person command. Some part of the codes were adapted and modified.
- Added
delete-scommand features- What it does: Delete a seller by the given
indexfrom the user - Justifications: The basic CRUD command for the seller information
- Credits: The feature was implemented by referring to AddressBook Level 3 (AB3) delete person command. Some part of the codes were adapted and modified.
- What it does: Delete a seller by the given
- Added
propertyfeatures into thebuyerandseller- What it does: This feature is to store the key information from a buyer and a seller, it is to show the information of the property that a buyer/seller wish to buy/sell.
- Justifications: This is the essential information for both a buyer and a seller, and it is made associated with buyer/seller.
The
matchcommand also uses the property feature to match a buyer and with many sellers. - Highlights: This feature is implemented using OOP concept.
- Improve the storage system of the project
- Created a lot of classes like
JSONAdaptedBuyer/Seller,JSONAdaptedPropertyand related properties classes to make the storage system be able to store essential information about buyers and sellers,propertyToBuyandpropertyToSell - Updated the
modelclass and thelogicManagerclass to match the current implementation - Updated the JSON format that the app saves, and the ability to read the files.
- Remove unused storage related files like
Clientrelated classes.
- Created a lot of classes like
- Update the UI of the project
- Let buyers and sellers be able to show its eseestial information on the UI
- Make initial changes to the UI
- Credits: The UI was made complete with Wang Jun Hong and Bian Yuqi
- Code quality control of the project
- Delete all unused files and commented out codes
- Make sure all naming conventions of the files are appropriate by refactoring the classes’ name and methods’ name
- Added test cases for
EditSellerandEditBuyerclasses - Added test cases for
Storagerelated classes - Refactored test cases to match the current version
- Added
- Project management:
- Fixed a bug on the project #84
- Give ideas to teammates while planning on the next iteration
- Actively discuss with teammates in order to maintain the consistency in our project
- Increase code coverage by adding more test cases.
- Add issues in the Github to keep track of the progress in out project.
- Documentation:
- User Guide:
- Update documentation for the command
add - Update documentation for the file system, explain about the data structure of our JSON format in details
- Made some changes so that it is updated to our current version.
- Update documentation for the command
- Developer Guide:
- Add a documentation about
EditBuyerandEditSellercommand - Add a detailed UML diagram about the sequence diagram of
EditBuyerCommandandEditSellerCommandclass - Add detailed explanation when executing
EditBuyerandEditSellercommand - Add detailed explanation on Saving data sections, explaining how to handle the corrupt data files and the correct format of data format.
- Update the glossary section so that it match our current version
- Add a documentation about
- User Guide:
- Community:
- Significant Pull Request made:
- ‘editseller’ command
- JSON format: UI rendering Property
- Correct format on saving storage and reading JSON file
- Update UI and refactor some class name
- Branch remove client related commands
- Removed all unused files and commented out codes
- Bug fix
- Add House Class, HouseType, Location, and PriceRange
- And many more here
- Pull Request reviewed: All PR reviewed can be found here
- One of them with non-trivial review comments: #72, where I give some commands on the code and potential typo and give approval
- Significant Pull Request made: